Skip to content

Bump version to 2.8.1#254

Merged
igerber merged 1 commit into
mainfrom
release/v2.8.1
Apr 1, 2026
Merged

Bump version to 2.8.1#254
igerber merged 1 commit into
mainfrom
release/v2.8.1

Conversation

@igerber
Copy link
Copy Markdown
Owner

@igerber igerber commented Apr 1, 2026

Summary

Methodology references (required if estimator / math changes)

  • N/A — version bump only, no methodology changes in this PR

Validation

  • Tests added/updated: No test changes (version bump only)
  • Backtest / simulation / notebook evidence: N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

Adds CHANGELOG entry covering survey tutorial (Phase 7c), survey R
cross-validation against survey::svyglm, HonestDiD methodology review
and validation, and StaggeredTripleDifference survey support.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

PR Review

Overall assessment: ✅ Looks good

Executive summary

  • The diff is release metadata only: changelog entry plus version bumps in Python, Rust, and the LLM-facing docs (CHANGELOG.md:L10-L29, diff_diff/__init__.py:L213, pyproject.toml:L7, rust/Cargo.toml:L3, docs/llms-full.txt:L5).
  • No estimator implementation, weighting logic, variance/SE computation, identification assumption, or default behavior changed in this PR.
  • Version propagation appears complete and internally consistent. Docs build versioning is sourced from diff_diff.__version__ (docs/conf.py:L19-L20), and the Rust extension exports the Cargo package version (rust/src/lib.rs:L58).
  • No unmitigated P0/P1 findings. One low-risk documentation-validation gap remains, but it is already tracked in TODO.md:L87 and is not a blocker.

Methodology

No findings.

The changelog mentions methodology-adjacent work for HonestDiD and StaggeredTripleDifference (CHANGELOG.md:L13-L29), but this PR does not modify those implementations. Cross-checking the existing registry entries shows the relevant methodology/deviation documentation already lives in docs/methodology/REGISTRY.md:L1263-L1404 and docs/methodology/REGISTRY.md:L1778-L1827.

Code Quality

No findings.

The version bump is propagated consistently across packaging/runtime surfaces: pyproject.toml:L7, diff_diff/__init__.py:L213, rust/Cargo.toml:L3, and docs/llms-full.txt:L5. The changelog also includes the new compare link at CHANGELOG.md:L1068.

Performance

No findings.

This is a metadata-only PR and does not touch runtime code paths.

Maintainability

No findings.

The version sources remain straightforward and low-drift because Sphinx reads diff_diff.__version__ (docs/conf.py:L19-L20) and the Rust module exports CARGO_PKG_VERSION (rust/src/lib.rs:L58).

Tech Debt

No findings.

This PR does not introduce new deferred work or add untracked release-process debt.

Security

No findings.

No secrets, credentials, network behavior, or executable logic changed in the diff.

Documentation/Tests

  • Severity: P3
    Impact: docs/llms-full.txt:L5 was updated manually, and .txt AI guide files are still outside current snippet smoke coverage, which is already tracked in TODO.md:L87. This creates a small documentation-drift risk but does not affect package correctness.
    Concrete fix: None required for approval. Separately, extend tests/test_doc_snippets.py or equivalent coverage to include .txt guide files if CI validation for these docs is desired.

@igerber igerber merged commit 19bad25 into main Apr 1, 2026
15 checks passed
@igerber igerber deleted the release/v2.8.1 branch April 1, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant